Change in vdsm[master]: virt: Switch from minidom to etree in DomainDescriptor

fromani at redhat.com fromani at redhat.com
Fri Jan 22 08:21:23 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Switch from minidom to etree in DomainDescriptor
......................................................................


Patch Set 2:

(1 comment)

I like this direction. I wonder if there is any way to reduce the size of this patch.

https://gerrit.ovirt.org/#/c/51034/2/tests/vmOperationsTests.py
File tests/vmOperationsTests.py:

Line 128: 
Line 129:     def testUpdateSingleDeviceGraphics(self):
Line 130:         devXmls = (
Line 131:             '<graphics connected="disconnect" passwd="12345678"'
Line 132:             ' port="5900" type="spice" />',
no big deal, but why is this needed?
Line 133:             '<graphics passwd="12345678" port="5900" type="vnc" />')
Line 134:         for device, devXml in zip(self.GRAPHIC_DEVICES, devXmls):
Line 135:             domXml = '''
Line 136:                 <devices>


-- 
To view, visit https://gerrit.ovirt.org/51034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4185f3b46e8034c594bd28af71bbcb1978039a15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list