Change in vdsm[master]: net api: Canonize the network bridged flag

danken at redhat.com danken at redhat.com
Fri Jan 22 08:20:47 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net api: Canonize the network bridged flag
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/52482/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 746:     if 'vlan' in networkAttrs and topNetDev:
Line 747:         vlan_name = '%s.%s' % (topNetDev.name, networkAttrs['vlan'])
Line 748:         if vlan_name in _netinfo.vlans:
Line 749:             topNetDev = Vlan(topNetDev, networkAttrs['vlan'], configurator)
Line 750:     if networkAttrs['bridged']:
a  tobool(get()) remains in lib/vdsm/network/configurators/ifcfg.py line 923
Line 751:         if network in _netinfo.bridges:
Line 752:             topNetDev = Bridge(network, configurator, port=topNetDev)
Line 753: 
Line 754:     if topNetDev:


-- 
To view, visit https://gerrit.ovirt.org/52482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a58b356718f4239e081afcd1bf690ae5756a5b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list