Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

fromani at redhat.com fromani at redhat.com
Thu Jan 21 14:49:50 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: stats: make _disk_iops_bytes more robust
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/50594/11/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 354: 
Line 355:     for name, suffix in (('readOps', 'rd.reqs'),
Line 356:                          ('writeOps', 'wr.reqs'),
Line 357:                          ('readBytes', 'rd.bytes'),
Line 358:                          ('writtenBytes', 'wr.bytes')):
> Not so important naming/consistency thing again. I would rather see 3-tuple
Fair enough, done!
Line 359:         key = 'block.%d.%s' % (last_index, suffix)
Line 360:         try:
Line 361:             value = last_sample[key]
Line 362:         except KeyError:


-- 
To view, visit https://gerrit.ovirt.org/50594
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341779e2629a1122e4c0fa55206ad404f3eb2f48
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list