Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.
fromani at redhat.com
fromani at redhat.com
Thu Jan 21 10:55:21 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
partial ACK, deeper review (to make sure all differences between 3.5 and 3.6 are taken into account) later.
https://gerrit.ovirt.org/#/c/52463/4/tests/vmTests.py
File tests/vmTests.py:
Line 851: zip(devConfs, expectedXMLs, blockDevs, vmConfs):
Line 852: drive = vm.Drive(vmConf, self.log, **devConf)
Line 853: # Patch Drive.blockDev to skip the block device checking.
Line 854: drive._blockDev = blockDev
Line 855: xmlForCompare = xml if devConf['device'] == 'lun' else xml % SERIAL
> This works, since xml % SERIAL is used only for other devices, lun xml is u
OK, I was wrong :)
Line 856: self.assertXML(drive.getXML(), xmlForCompare)
Line 857:
Line 858: def testIoTuneException(self):
Line 859: SERIAL = '54-a672-23e5b495a9ea'
--
To view, visit https://gerrit.ovirt.org/52463
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list