Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 21 08:32:24 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................


Patch Set 3: Code-Review-1

Please fix the tests and make sure the tests are successful locally before you upload patches to gerrit.

16:21:36 ======================================================================
16:21:36 FAIL: testDriveXML (vmTests.TestVm)
16:21:36 ----------------------------------------------------------------------
16:21:36 Traceback (most recent call last):
16:21:36   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el6-x86_64/vdsm/tests/vmTests.py", line 856, in testDriveXML
16:21:36     self.assertXML(drive.getXML(), xml % SERIAL)
16:21:36   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el6-x86_64/vdsm/tests/vmTests.py", line 180, in assertXML
16:21:36     re.sub('\n\s*', ' ', expectedXML).strip(' '))
16:21:36 AssertionError: '<disk device="lun" sgio="unfiltered" snapshot="no" type="block"> <source dev="/dev/mapper/lun1"/> <target bus="scsi" dev="sda"/> <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/> </disk>' != '<disk device="lun" sgio="unfiltered" snapshot="no" type="block"> <source dev="/dev/mapper/lun1"/> <target bus="scsi" dev="sda"/> <serial>54-a672-23e5b495a9ea</serial> <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/> </disk>'

-- 
To view, visit https://gerrit.ovirt.org/52463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list