Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 21 07:54:53 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 32:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py
File tests/v2vTests.py:

Line 317:                                 _connect)]):
Line 318:             vms = v2v.get_external_vms('esx://mydomain', 'user',
Line 319:                                        ProtectedPassword('password')
Line 320:                                        )['vmList']
Line 321:             self.assertEqual(len(vms), len(self._vms))
> This is not a failed vm but a failed api ie listAllDomains is not supported
You should simulate failue of this api, and then check that the returned vm list is expected.
Line 322: 
Line 323:     def testOutputParser(self):
Line 324:         output = ''.join(['[   0.0] Opening the source -i libvirt ://roo...\n',
Line 325:                           '[   1.0] Creating an overlay to protect the f...\n',


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eblake at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list