Change in vdsm[master]: net: Cleanup _create_socket from dead code

danken at redhat.com danken at redhat.com
Wed Jan 20 16:41:34 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Cleanup _create_socket from dead code
......................................................................


net: Cleanup _create_socket from dead code

On failure, socket.getaddrinfo() raises an exception and does not return
a None.

Change-Id: I80415147d7c0480fed47b0606df53c6658f405e9
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52462
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M vdsm/protocoldetector.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/52462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80415147d7c0480fed47b0606df53c6658f405e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list