Change in vdsm[master]: vdsm: introduce cpuinfo module
nsoffer at redhat.com
nsoffer at redhat.com
Wed Jan 20 13:50:27 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
......................................................................
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/27/tests/cpuinfo_test.py
File tests/cpuinfo_test.py:
Line 54: self.assertEqual(cpuinfo.model(),
Line 55: 'Intel(R) Xeon(R) CPU E5649 @ 2.53GHz')
Line 56:
Line 57: @MonkeyPatch(cpuinfo, '_PATH',
Line 58: lambda: _outfile('cpuinfo_POWER8E_ppc64le.out'))
_PATH is not a funciton, no need for lambda. We are replacing one string with another.
Did you try to run these tests before posting a new patch?
Line 59: @MonkeyPatch(platform, 'machine', lambda: cpuarch.PPC64LE)
Line 60: def test_cpuinfo_POWER8E_ppc64le(self):
Line 61: self.assertEqual(cpuinfo.flags(), ['powernv'])
Line 62: self.assertEqual(cpuinfo.frequency(), '3690.000000')
--
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list