Change in vdsm[master]: virt: stats: make compute_latency more robust

fromani at redhat.com fromani at redhat.com
Wed Jan 20 12:59:35 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: stats: make compute_latency more robust
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/50593/10/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 320: 
Line 321:     return stats
Line 322: 
Line 323: 
Line 324: def _compute_latency(first_sample, first_index,
please check the simplification attempt in https://gerrit.ovirt.org/#/c/52498/1
Line 325:                      last_sample, last_index, mode):
Line 326:     operations = (
Line 327:         last_sample['block.%d.%s.reqs' % (last_index, mode)] -
Line 328:         first_sample['block.%d.%s.reqs' % (first_index, mode)]


-- 
To view, visit https://gerrit.ovirt.org/50593
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4670309d48bd65a3afaba8124407598b76d808d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list