Change in vdsm[master]: build: make lib/api directory writable

danken at redhat.com danken at redhat.com
Wed Jan 20 10:39:02 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: build: make lib/api directory writable
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/52481/1/lib/api/Makefile.am
File lib/api/Makefile.am:

Line 45: 	$(NULL)
Line 46: 
Line 47: vdsm-api.html: process-schema.py vdsmapi-schema.json
Line 48: 	@echo "  Generate $@"
Line 49: 	chmod u+w $(srcdir)
> you should be able to use CHMOD_PATH
everywhere in Makefile.am we use chmod, which I personally prefer.
Line 50: 	PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=$(srcdir)/../lib \
Line 51: 	    $(PYTHON) $(srcdir)/process-schema.py \
Line 52: 	              $(srcdir)/vdsmapi-schema.json $(srcdir)/$@
Line 53: 


-- 
To view, visit https://gerrit.ovirt.org/52481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15c059e65130c9e9f8daa75f6e7e89eb3c687fff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list