Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge
nsoffer at redhat.com
nsoffer at redhat.com
Tue Jan 19 23:50:11 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py
File tests/bridgeTests.py:
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: import imp
Line 22:
Line 23: from vdsm.exception import HookError
Better use GeneralExeption, since this code is not about HookError but generic exception handler. And this way I can also merge this and the previous patch *now*.
Line 24: from rpc.Bridge import DynamicBridge
Line 25: from yajsonrpc import JsonRpcError
Line 26:
Line 27: from monkeypatch import MonkeyPatch
Line 21: import imp
Line 22:
Line 23: from vdsm.exception import HookError
Line 24: from rpc.Bridge import DynamicBridge
Line 25: from yajsonrpc import JsonRpcError
This import seems unused.
Line 26:
Line 27: from monkeypatch import MonkeyPatch
Line 28: from testlib import VdsmTestCase as TestCaseBase
Line 29:
--
To view, visit https://gerrit.ovirt.org/51549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list