Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 19 23:39:14 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG
Commit Message:

Line 7: lun: Serial attr should not passed to libvirt for lun disks.
Line 8: 
Line 9: Following the change which was introduced at
Line 10: libvirt-1.2.17-5 and qemu-kvm-rhev-2.3.0-18, libvirt now enforce
Line 11: that a scsi-block 'lun' device should not provide the 'serial' property.
> For EL7 we require libvirt-1.2.8-16.el7_1.4. So this behavior should either
According to the bug, libvirt use to ignore the serial value in old versions, so not specifying it should be compatible with older versions.

We should check that the versions we required on rhel 7 and 6 works with this change. I don't see any reason to require new versions.
Line 12: 
Line 13: To comply with this change, this patch introduces a change
Line 14: that a VM should ignore 'serial' property for lun devices when
Line 15: passing the XML to libvirt.


-- 
To view, visit https://gerrit.ovirt.org/52463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list