Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Jan 19 17:36:17 UTC 2016


Hello Nir Soffer,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/52463

to review the following change.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................

lun: Serial attr should not passed to libvirt for lun disks.

Following the change which was introduced at
libvirt-1.2.17-5 and qemu-kvm-rhev-2.3.0-18, libvirt now enforce
that a scsi-block 'lun' device should not provide the 'serial' property.

To comply with this change, this patch introduces a change
that a VM should ignore 'serial' property for lun devices when
passing the XML to libvirt.

This patch was verified by running a VM with lun disk which
had enabled SCSI Pass-Through and also plugging the same lun disk
while the VM was running. The operation succeeded.

Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Bug-Url: https://bugzilla.redhat.com/1291930
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Tested-by: Maor Lipchuk <mlipchuk at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51766
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/52463/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ec58289..f6ba328 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1565,7 +1565,7 @@
             # floppies are used only internally for sysprep, so
             # they are readonly unless explicitely stated otherwise
             diskelem.appendChildWithArgs('readonly')
-        if hasattr(self, 'serial'):
+        if hasattr(self, 'serial') and self.device != 'lun':
             diskelem.appendChildWithArgs('serial', text=self.serial)
         if hasattr(self, 'bootOrder'):
             diskelem.appendChildWithArgs('boot', order=self.bootOrder)


-- 
To view, visit https://gerrit.ovirt.org/52463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list