Change in vdsm[master]: net: Enable VDSM to perform migration over IPv6

fromani at redhat.com fromani at redhat.com
Tue Jan 19 15:47:41 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: net: Enable VDSM to perform migration over IPv6
......................................................................


Patch Set 3:

(1 comment)

looks good, partial ACK because one question inside.

https://gerrit.ovirt.org/#/c/51933/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 127:     def _createClient(self, port):
Line 128:         sslctx = sslutils.create_ssl_context()
Line 129: 
Line 130:         def is_ipv6_address(a):
Line 131:             return (':' in a) and a.startswith('[') and a.endswith(']')
I don't mind this inner function here, but are you sure there is not something similar already in the codebase
Line 132: 
Line 133:         if is_ipv6_address(self.remoteHost):
Line 134:             host = self.remoteHost[1:-1]
Line 135:         else:


-- 
To view, visit https://gerrit.ovirt.org/51933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id12e6df9004737ea6eec450d2e07cbb10aaa104a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list