Change in vdsm[master]: net: Enable VDSM to perform migration over IPv6

edwardh at redhat.com edwardh at redhat.com
Tue Jan 19 13:13:34 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Enable VDSM to perform migration over IPv6
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/51933/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 130: ipv6 tool module
> I'm not sure what are you referring to.
I refer to tooling for IP stuff.
netinfo/addresses are related to netinfo, I want it independently so other will use it all over without depending on netinfo.

We should have IP, SOCKET and similar tool wrappers.

Anyway, removed.


Line 132: a.count(':')
> (':' in a) is a more straight-forward way to test this.
Done


Line 134: \
> trailing backslashes are quite ugly. I'd rather use parenthesis, or a multi
They are both ugly, I prefer we extend the line len :)
Ok, will fix.


-- 
To view, visit https://gerrit.ovirt.org/51933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id12e6df9004737ea6eec450d2e07cbb10aaa104a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list