Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4

edwardh at redhat.com edwardh at redhat.com
Tue Jan 19 11:35:46 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: When IPv6 is not enabled, fallback to IPv4
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 116: 
Line 117:             host = config.get('addresses', 'management_ip')
Line 118:             port = config.getint('addresses', 'management_port')
Line 119: 
Line 120:             # When IPv6 is not enabled, fallback to listen on IPv4 address
> Why clientIF need to know any of this details?
Originally it was in the low level socket creation and then Dan remarked that this 'fallback' logic should not be in the 'driver' but at the caller.
Rephrasing: It's ClinetIF logic decision to fallback to IPv4 if IPv6 acceptor creation fails.
Line 121:             try:
Line 122:                 self._createAcceptor(host, port)
Line 123:             except socket.error as e:
Line 124:                 if e.errno == errno.EAFNOSUPPORT and host in ('::', '::1'):


https://gerrit.ovirt.org/#/c/52366/1/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 34: 
> this is a very awkward exception that we are raising here; but why removing
Yes, this is a cleanup I did when editing this portion (when the fallback logic was here).
This is actually dead code, can't we just leave this cleanup here?


-- 
To view, visit https://gerrit.ovirt.org/52366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list