Change in vdsm[master]: vm: make deleteVm private

danken at redhat.com danken at redhat.com
Tue Jan 19 11:29:39 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: make deleteVm private
......................................................................


vm: make deleteVm private

The Vm.deleteVm() method is never used outside the Vm class,
so it should be _private.

Change-Id: I217637023185ec428cb66dfb8fe93b6c3bb98c32
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51384
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51384
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I217637023185ec428cb66dfb8fe93b6c3bb98c32
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list