Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

fromani at redhat.com fromani at redhat.com
Tue Jan 19 09:18:17 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: vm: safer handling of conf in restore
......................................................................


vm: safer handling of conf in restore

In the restore state (aka dehibernation) path, there
are a few places left on which the code mutates
Vm.conf without the protection of the confLock.
There is no obvious reason to have those mutations
unguarded, so this patch adds the confLock protection.

Change-Id: Ia46be9c779589b8c27395ced7904efb7de8cacc7
Backport-To: 3.6
Backport-To: 3.5
Bug-Url: https://bugzilla.redhat.com/1298190
Related-To: https://bugzilla.redhat.com/1296936
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51657
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51829
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52343
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia46be9c779589b8c27395ced7904efb7de8cacc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list