Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

fromani at redhat.com fromani at redhat.com
Tue Jan 19 09:17:27 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: virt: safer handling of migration parameters
......................................................................


virt: safer handling of migration parameters

The Migration Source code path needs to store additional
transient migration parameters in the Vm configuration state,
to be both saved on recovery file and transmitted on the
destination VM.
Those parameters will be dropped once the migration is done.

Up until now, the migration code mangled the Vm state from the outside.
This was ugly and unsafe, because the configuration was mutated without
any locking.

Under high migration load, this can lead to RuntimeErrors, because
the clients of Vm.conf (e.g. status(), getVMList()...) expect the
lock being held and the access serialized.

To fix those issues, we add a helper method into Vm class, to
let the migration code temporarily store the data it needs in a safe
and simple way.

Change-Id: I063d74c1fe1725c514f7aeb60463d0558e240baa
Backport-To: 3.6
Backport-To: 3.5
Bug-Url: https://bugzilla.redhat.com/1298190
Related-To: https://bugzilla.redhat.com/1296936
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51656
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51828
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52342
---
M tests/vmTests.py
M vdsm/virt/migration.py
M vdsm/virt/vm.py
3 files changed, 41 insertions(+), 8 deletions(-)

Approvals:
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I063d74c1fe1725c514f7aeb60463d0558e240baa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list