Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

danken at redhat.com danken at redhat.com
Mon Jan 18 14:28:25 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: supervdsm: failed validateAccess leaves pipes open
......................................................................


supervdsm: failed validateAccess leaves pipes open

Whenever we run validateAccess and it fails with "Permission denied" we
leak file descriptors. We need to make sure to close child and parent
pipes.


Change-Id: I6356837686c274389e92e828143cce3a5eeff564
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-url: https://bugzilla.redhat.com/1271575
Reviewed-on: https://gerrit.ovirt.org/51850
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 26 insertions(+), 24 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list