Change in vdsm[master]: resourceManager: Fix ResourceRef leak

fromani at redhat.com fromani at redhat.com
Mon Jan 18 10:44:57 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: resourceManager: Fix ResourceRef leak
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

seems ok, one question inside but for my understanding.

https://gerrit.ovirt.org/#/c/51917/3/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:

Line 297:                 continue
Line 298: 
Line 299:             weakmethod = partial(ResourceRef.__methodProxy,
Line 300:                                  weakref.proxy(self), attr)
Line 301:             setattr(self, attr, weakmethod)
looks good. For my understanding, you can't use our new utils.weakmethod() because of the use of partial(), right?
Line 302: 
Line 303:     def __methodProxy(self, attr, *args, **kwargs):
Line 304:         with self._syncRoot.shared:
Line 305:             if not self.isValid:


-- 
To view, visit https://gerrit.ovirt.org/51917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890616ba53ee70688ee00ea337ebc566d63f861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list