Change in vdsm[master]: test: Configurable verbose test output

edwardh at redhat.com edwardh at redhat.com
Sun Jan 17 14:48:06 UTC 2016


Edward Haas has posted comments on this change.

Change subject: test: Configurable verbose test output
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/51772/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Let the user control verbose level.
Line 10: 
Line 11: To run without verbose output, use: 'NOSE_VERBOSE=1'
Line 12: Example: 'make check NOSE_VERBOSE=1'
> Please document this also in tests/README
Done
Line 13: 
Line 14: Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33


https://gerrit.ovirt.org/#/c/51772/2/tests/run_tests.sh.in
File tests/run_tests.sh.in:

Line 3
Line 4
Line 5
Line 6
Line 7
> Better add this here like LC_ALL and PYTHONPATH
Done


https://gerrit.ovirt.org/#/c/51772/2/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

Line 2
Line 3
Line 4
Line 5
Line 6
> Better add this on the LC_ALL line
Done


Line 2: if [ -z "$PYTHON_EXE" ]; then
Line 3:     PYTHON_EXE="@PYTHON@"
Line 4: fi
Line 5: 
Line 6: export NOSE_VERBOSE=${NOSE_VERBOSE-3}
> Do you mean ${NOSE_VERBOSE:-3} ?
Almost the same: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

But I actually need now ':='


-- 
To view, visit https://gerrit.ovirt.org/51772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list