Change in vdsm[master]: host: use cpuarch

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 17 01:00:35 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: host: use cpuarch
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/51434/6/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 42
Line 43
Line 44
Line 45
Line 46
Previously we accepted also "i686", now we will fail with cpuarch.UnsupportedArchitecture. Is this change intended?


Line 56:                     # Avoid error string - 'Not Settable' or 'Not Present'
Line 57:                     __hostUUID = out.strip()
Line 58:                 else:
Line 59:                     logging.warning('Could not find host UUID.')
Line 60:             elif cpuarch.is_ppc(arch):
is_ppc does not match "ppc", only "ppc64" and "ppc64le". Is this change intended?
Line 61:                 # eg. output IBM,03061C14A
Line 62:                 try:
Line 63:                     with open('/proc/device-tree/system-id') as f:
Line 64:                         systemId = f.readline()


-- 
To view, visit https://gerrit.ovirt.org/51434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dcb227de8e97e138bdf13e91cccb081bdb8bdd5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list