Change in vdsm[master]: testlib: use arch from lib

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 17 00:55:56 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: testlib: use arch from lib
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

The correct change is to remove _vdsm_machine and do the monkey patching in the tests that need to patch cpuarch.

https://gerrit.ovirt.org/#/c/49973/11/tests/testlib.py
File tests/testlib.py:

Line 170
Line 171
Line 172
Line 173
Line 174
Francesco, why do we need this in testlib?

If we have tests that want to patch cpuarch, they can patch it. This will be removed when we move to py.test, so you should move the patching where it belongs.


-- 
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list