Change in vdsm[master]: test: Configurable verbose test output

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 16 21:28:48 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: test: Configurable verbose test output
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/51772/2/tests/run_tests.sh.in
File tests/run_tests.sh.in:

Line 3
Line 4
Line 5
Line 6
Line 7
Better add this here like LC_ALL and PYTHONPATH

If you think that defining the environment as one export line per variable is better, please send another patch converting the files to this format, before your patch.


https://gerrit.ovirt.org/#/c/51772/2/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

Line 2
Line 3
Line 4
Line 5
Line 6
Better add this on the LC_ALL line


Line 2: if [ -z "$PYTHON_EXE" ]; then
Line 3:     PYTHON_EXE="@PYTHON@"
Line 4: fi
Line 5: 
Line 6: export NOSE_VERBOSE=${NOSE_VERBOSE-3}
Do you mean ${NOSE_VERBOSE:-3} ?


-- 
To view, visit https://gerrit.ovirt.org/51772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list