Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

fromani at redhat.com fromani at redhat.com
Fri Jan 15 15:53:17 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: virt: Correct epoll unregistration usage in vmchannels
......................................................................


virt: Correct epoll unregistration usage in vmchannels

Previously we have been unregistering fds from epoll but not in the correct
way. Which has led to log messages which seemed to have no good explanation
as of why they occur. That has been changed to 'fix' it by letting only epoll
unregister those file descriptors themselves when they are closed.
This however has been wrong - the correct procedure to use epoll is to
unregister the file descriptor first and then close the socket.

In the vmchannel case there are two scenarios where this applies:

- On an error reported by epoll
- When we want to unregister the channel from vmchannels

This patch fixes those two scenarios.

Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Backport-To: 3.5
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1297414
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51521
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Continuous-Integration: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/51841
Continuous-Integration: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vmchannels.py
1 file changed, 31 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve; Passed CI tests
  Vinzenz Feenstra: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list