Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

fromani at redhat.com fromani at redhat.com
Fri Jan 15 15:53:04 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Correct epoll unregistration usage in vmchannels
......................................................................


Patch Set 7: Continuous-Integration+1

same as parent patch. The test error is irrelevant (we already seen it multiple times). Run check-local manually:

1226 16:50:50 fromani at musashi ~/Projects/upstream/vdsm $ git log --oneline -1 && make check-local
3147b6c virt: Correct epoll unregistration usage in vmchannels
python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
pyflakes-1.0.0
find . -path './.git' -prune -type f -o \
	-name '*.py' -o -name '*.py.in'  | xargs /usr/bin/pyflakes | \
	grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \
	while read LINE; do echo "$LINE"; false; done
/usr/bin/pep8 --version
1.5.7
for x in config.py constants.py crossImportsTests.py vdsm.py ; do \
    exclude="${exclude},${x}" ; \
done ; \
/usr/bin/pep8 --exclude="${exclude}" --filename '*.py,*.py.in' .
/usr/bin/pep8 contrib/profile-stats init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool vds_bootstrap/setup 

So, seems good to go.

-- 
To view, visit https://gerrit.ovirt.org/51841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list