Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

phoracek at redhat.com phoracek at redhat.com
Fri Jan 15 14:11:14 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: enable auto-attach mapping
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py:

Line 166:                 if 'bonding' in attrs else [attrs['nic']])
Line 167:             for interface in interfaces:
Line 168:                 command.extend(['--', 'set', 'Interface', interface,
Line 169:                                 'lldp:enable=true'])
Line 170:             command.extend(['--', 'add-aa-mapping', network, sid, vlan])
> I am asking if the purpose of the method is just to replace a mapping, or a
Aha! It should handle mapping according to given query. If no mapping is defined, we should remove it (if it exists); if there is different configuration, remove it and add new; if there was no mapping before, add it. So it should handle everything.
Line 171: 
Line 172:     return command
Line 173: 
Line 174: 


-- 
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list