Change in vdsm[master]: tests: extend coverage for vmstats.disks()

danken at redhat.com danken at redhat.com
Fri Jan 15 11:37:47 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: extend coverage for vmstats.disks()
......................................................................


tests: extend coverage for vmstats.disks()

This patch extends the test coverage for vmstats.disks()

- make existing test helpers clearer avoiding default arguments
- make existing test clearer adding explicit data
- add test for zero-interval, which sometimes happens during
  migrations and it is already handled by the code.

Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1281337
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51854
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmStatsTests.py
1 file changed, 51 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/51854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list