Change in vdsm[master]: tests: extend coverage for vmstats.disks()
mzamazal at redhat.com
mzamazal at redhat.com
Fri Jan 15 09:29:16 UTC 2016
Milan Zamazal has posted comments on this change.
Change subject: tests: extend coverage for vmstats.disks()
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Fine for me except the PEP8 violation and the typo in the commit message.
https://gerrit.ovirt.org/#/c/51854/2//COMMIT_MSG
Commit Message:
Line 11: argoments
... arguments
https://gerrit.ovirt.org/#/c/51854/2/tests/vmStatsTests.py
File tests/vmStatsTests.py:
Line 405: self.assertRepeatedStatsHaveKeys(drives, stats['disks'],
Line 406: self._EXPECTED_KEYS)
Line 407:
Line 408:
Line 409: def test_interval_zero(self):
PEP8: Too many blank lines.
Line 410: interval = 0 # seconds
Line 411: # with zero interval, we won't have {read,write}Rate
Line 412: expected_keys = tuple(k for k in self._EXPECTED_KEYS
Line 413: if k not in ('readRate', 'writeRate'))
--
To view, visit https://gerrit.ovirt.org/51854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list