Change in vdsm[master]: hooks: ovs: enable auto-attach mapping
mmirecki at redhat.com
mmirecki at redhat.com
Fri Jan 15 09:00:37 UTC 2016
Marcin Mirecki has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py:
Line 160: if init_sid is not None:
: command.extend(['--', 'del-aa-mapping', network, init_sid,
: init_vlan])
: if sid is not None:
: interfaces = (
: running_config.bonds.get(attrs['bonding'])['nics']
: if 'bonding' in attrs else [attrs['nic']])
: for interface in interfaces:
: command.extend(['--', 'set', 'Interface', interface,
: 'lldp:enable=true'])
: command.extend(['--', 'add-aa-mapping', network, sid, vlan])
If either init_sid or sid is None, then we will just delete a mapping or just add a mapping.
Would this be the correct behaviour?
--
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list