Change in vdsm[master]: utils: add weakmethod helper

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Jan 15 06:54:38 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: utils: add weakmethod helper
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py
File tests/utilsTests.py:

Line 1057: 
Line 1058:         self.assertIn(FakeVirDomain,
Line 1059:                       (inst.__class__ for inst in (after - before)))
Line 1060: 
Line 1061:     def test_without_reference_cycle(self):
> well I am not sure I like this, but you're duplicating the code here, could
Or use the permutations decorator?
Line 1062: 
Line 1063:         # test environment is too noisy
Line 1064:         gc.collect()
Line 1065:         before = set(gc.garbage)


-- 
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list