Change in vdsm[master]: lib: use weakmethod to break reference cycles

fromani at redhat.com fromani at redhat.com
Thu Jan 14 16:08:26 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: lib: use weakmethod to break reference cycles
......................................................................


Patch Set 4:

Michal, sure thing, let me amend my commit message to read something like

 This patch uses utils.weakmethod to break the reference cycle in a backport-friandly manner, in order to make the objects collectable again, and to avoid the leak.

  The proper long-term fix is to rethink the wrapping done in libvirtconnection.py, but this will be addressed in a future patch.

-- 
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list