Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Jan 14 15:16:47 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Correct epoll unregistration usage in vmchannels
......................................................................


Patch Set 2: Verified+1

Verified on 3.5 branch migrated vms back and forth, started and stopped vms and restarted vdsm - no issues 



CI Error unrelated: 
1:04:17 ======================================================================
11:04:17 ERROR: test_parseVolumeStatus (gluster_cli_tests.GlusterCliTests)
11:04:17 ----------------------------------------------------------------------
11:04:17 Traceback (most recent call last):
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/gluster_cli_tests.py", line 1083, in test_parseVolumeStatus
11:04:17     self._parseVolumeStatus_test()
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/gluster_cli_tests.py", line 268, in _parseVolumeStatus_test
11:04:17     status = gcli._parseVolumeStatus(tree)
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/vdsm/gluster/cli.py", line 137, in _parseVolumeStatus
11:04:17     hostname = _getLocalIpAddress() or _getGlusterHostName()
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/vdsm/gluster/cli.py", line 107, in _getLocalIpAddress
11:04:17     for ip in netinfo.getIpAddresses():
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/lib/vdsm/netinfo.py", line 796, in getIpAddresses
11:04:17     return filter(None, [getaddr(i) for i in ethtool.get_active_devices()])
11:04:17   File "/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/lib/vdsm/netinfo.py", line 300, in getaddr
11:04:17     dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8'))
11:04:17 UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 5: ordinal not in range(128)

-- 
To view, visit https://gerrit.ovirt.org/51841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list