Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Jan 14 15:16:25 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: supervdsm: failed validateAccess leaves pipes open
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51850/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 290:             return res
Line 291: 
Line 292:         finally:
Line 293:             pipe.close()
Line 294:             hisPipe.close()
> This is not good enough. If we fail in line 266, this will not be called.
Done
Line 295: 
Line 296:             # Add to zombiereaper if process has not been waited upon
Line 297:             if proc.exitcode is None and needReaping:
Line 298:                 zombiereaper.autoReapPID(proc.pid)


-- 
To view, visit https://gerrit.ovirt.org/51850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list