Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 14 13:20:21 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: lun: Serial attr should not passed to libvirt for lun disks.
......................................................................


lun: Serial attr should not passed to libvirt for lun disks.

Following the change which was introduced at
libvirt-1.2.17-5 and qemu-kvm-rhev-2.3.0-18, libvirt now enforce
that a scsi-block 'lun' device should not provide the 'serial' property.

To comply with this change, this patch introduces a change
that a VM should ignore 'serial' property for lun devices when
passing the XML to libvirt.

This patch was verified by running a VM with lun disk which
had enabled SCSI Pass-Through and also plugging the same lun disk
while the VM was running. The operation succeeded.

Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Bug-Url: https://bugzilla.redhat.com/1291930
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Tested-by: Maor Lipchuk <mlipchuk at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51766
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/51766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41abb2b7d7f5950e65710379a0655399014afd83
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list