Change in vdsm[master]: vm: delete recovery file only after destroy()

mzamazal at redhat.com mzamazal at redhat.com
Thu Jan 14 11:37:12 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: vm: delete recovery file only after destroy()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51799/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3892:             del self.cif.vmContainer[self.conf['vmId']]
Line 3893:         except KeyError:
Line 3894:             self.log.exception("Failed to delete VM %s", self.conf['vmId'])
Line 3895:         else:
Line 3896:             self._cleanupRecoveryFile()
Can it happen that VM disappears from vmContainer elsewhere, so we don't call _cleanupRecoveryFile() here and we end up with stale recovery file?
Line 3897:             self.log.debug("Total desktops after destroy of %s is %d",
Line 3898:                            self.conf['vmId'], len(self.cif.vmContainer))
Line 3899: 
Line 3900:     def destroy(self):


-- 
To view, visit https://gerrit.ovirt.org/51799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list