Change in vdsm[master]: testlib: use arch from lib
fromani at redhat.com
fromani at redhat.com
Thu Jan 14 10:34:41 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
......................................................................
Patch Set 11:
(1 comment)
added a not in case you resubmit for whatever reason. Otherwise, looks good to me.
https://gerrit.ovirt.org/#/c/49973/11/tests/testlib.py
File tests/testlib.py:
Line 158: with open(path, "w") as f:
Line 159: f.truncate(size)
Line 160:
Line 161:
Line 162: def _vdsm_machine():
nit: now could be renamed like
_vdsm_arch
_vdsm_machine was intended to remind "platform.machine()"
not very important, however, and not worth a resubmit.
Line 163: try:
Line 164: return _ARCH_REAL
Line 165: except cpuarch.UnsupportedArchitecture:
Line 166: return cpuarch.X86_64
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list