Change in vdsm[master]: operstate: use python3-friendly io.open()

edwardh at redhat.com edwardh at redhat.com
Thu Jan 14 06:36:14 UTC 2016


Edward Haas has posted comments on this change.

Change subject: operstate: use python3-friendly io.open()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/51736/1/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 105: io
> io.open was introduced into Python 2.6 to make py3 porting easier.
I like this less than six in this context, just because you need to change the production code for the test.


-- 
To view, visit https://gerrit.ovirt.org/51736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877f01bf1fb79a7fbbe44416a70645b1da4afd01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list