Change in vdsm[master]: test: Do not force verbose test output

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 13 20:22:28 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: test: Do not force verbose test output
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51772/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Let the user explicitly enable verbose.
Line 10: 
Line 11: Tests, especially unit tests, are interesting when they fail
Line 12: and not when they pass.
> IMO skipping is a workaround, a clean test should either fail or pass. If a
There may many valid (and invalid) reasons to skip a test, and currently it is important to to make it easy to test skipped tests.

I practice TDD for several years, running the tests frequently, and I enjoy the verbose output.

We need to make it easy for people to run the tests as they like. For example, local config file e.g. nosetest.ini that that will let each developer run the test using the way she likes without arguing about the default setting.
Line 13: 
Line 14: To run with verbose output, use: 'NOSE_VERBOSE=3'
Line 15: Example: 'make check NOSE_VERBOSE=3'
Line 16: 


-- 
To view, visit https://gerrit.ovirt.org/51772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list