Change in vdsm[master]: migration: set timeout to 10 mins

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Jan 13 13:50:31 UTC 2016


Michal Skrivanek has posted comments on this change.

Change subject: migration: set timeout to 10 mins
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/51786/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 110:         return response.success()
Line 111: 
Line 112:     def _get_call_timeout(self, method_name, kwargs):
Line 113:         if method_name == 'migrationCreate':
Line 114:             return config.getint('vars', 'migration_timeout')
> Default timeout is 15 secs so far it was good enough. Do you have any sugge
destroy() would deserve more, but it's not so important and definitely doesn't justify a new parameter:-)
Line 115:         else:
Line 116:             return kwargs.pop('_transport_timeout', CALL_TIMEOUT)
Line 117: 
Line 118:     def migrationCreate(self, params):


-- 
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c30f972af5d96541a20c168bb27a9b3536ff247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list