Change in vdsm[master]: migration: set timeout to 10 mins

fromani at redhat.com fromani at redhat.com
Wed Jan 13 13:26:10 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: set timeout to 10 mins
......................................................................


Patch Set 2:

(2 comments)

looks good, a couple of questions and suggestions inside

https://gerrit.ovirt.org/#/c/51786/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 109: 
Line 110:         return response.success()
Line 111: 
Line 112:     def _get_call_timeout(self, method_name, kwargs):
Line 113:         if method_name == 'migrationCreate':
I wonder if it makes sense to have a dict with exceptions?
like

  self._timeouts = {
    'migrationCreate': config.getint('vars', 'migration_timeout'),
  }

probably will make sense if we have more exception to the general rule
Line 114:             return config.getint('vars', 'migration_timeout')
Line 115:         else:
Line 116:             return kwargs.pop('_transport_timeout', CALL_TIMEOUT)
Line 117: 


Line 110:         return response.success()
Line 111: 
Line 112:     def _get_call_timeout(self, method_name, kwargs):
Line 113:         if method_name == 'migrationCreate':
Line 114:             return config.getint('vars', 'migration_timeout')
So we ignore _transport_timeout, should it be present.
I guess this is OK, right?
Partially related: should we use the larget timeout if we have a choice? (thinking mostly about line 116 below)
Line 115:         else:
Line 116:             return kwargs.pop('_transport_timeout', CALL_TIMEOUT)
Line 117: 
Line 118:     def migrationCreate(self, params):


-- 
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c30f972af5d96541a20c168bb27a9b3536ff247
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list