Change in vdsm[master]: test: Do not force verbose test output

edwardh at redhat.com edwardh at redhat.com
Wed Jan 13 10:12:07 UTC 2016


Edward Haas has uploaded a new change for review.

Change subject: test: Do not force verbose test output
......................................................................

test: Do not force verbose test output

Let the user explicitly enable verbose.

Tests, especially unit tests, are interesting when they fail
and not when they pass.

To run with verbose output, use: 'NOSE_VERBOSE=3'
Example: 'make check NOSE_VERBOSE=3'

Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33
Signed-off-by: Edward Haas <edwardh at redhat.com>
---
M automation/check-patch.sh
M tests/testlib.py
2 files changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/51772/1

diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 259481e..7ab2644 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -6,7 +6,7 @@
 
 ./autogen.sh --system --enable-hooks
 
-make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib"
+make check NOSE_VERBOSE=3 NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib"
 
 ./automation/build-artifacts.sh
 
diff --git a/tests/testlib.py b/tests/testlib.py
index 7f028a4..94168dc 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -381,12 +381,10 @@
 def run():
     argv = sys.argv
     stream = sys.stdout
-    verbosity = 3
     testdir = os.path.dirname(os.path.abspath(__file__))
 
     conf = config.Config(stream=stream,
                          env=os.environ,
-                         verbosity=verbosity,
                          workingDir=testdir,
                          plugins=core.DefaultPluginManager())
     conf.plugins.addPlugin(SlowTestsPlugin())


-- 
To view, visit https://gerrit.ovirt.org/51772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>


More information about the vdsm-patches mailing list