Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

fromani at redhat.com fromani at redhat.com
Wed Jan 13 08:00:26 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Don't expose GuestAgent.guestInfo directly
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/51508/4/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 358:         if self.isResponsive():
Line 359:             # Returning deep copy would be safer but could have performance
Line 360:             # implications (e.g. on lists of thousands installed Windows
Line 361:             # packages).
Line 362:             return self.guestInfo.copy()
> Yes, but is it better to do that here or (in a separate patch) at the place
I think separate patch is appropriate. This flow proven to be tricky (first proof: we cannot just use the safest way, deepcopy/picklecopy, and we need some care), and this patch fixes the original issue.
But let's hear from Nir.
Line 363:         else:
Line 364:             return {
Line 365:                 'username': 'Unknown',
Line 366:                 'session': 'Unknown',


-- 
To view, visit https://gerrit.ovirt.org/51508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list