Change in vdsm[master]: Introducing context manager to terminate async processes on ...
nsoffer at redhat.com
nsoffer at redhat.com
Wed Jan 13 06:55:22 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: Introducing context manager to terminate async processes on internal fail
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/51407/6//COMMIT_MSG
Commit Message:
Line 14:
Line 15: p = execCmd([cmd], sync=False)
Line 16: with terminating(p):
Line 17: if proc.wait(30) is None:
Line 18: raise Timeout()
Example code looks nicer when it is indented.
Line 19:
Line 20:
Line 21: Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075
Line 16: with terminating(p):
Line 17: if proc.wait(30) is None:
Line 18: raise Timeout()
Line 19:
Line 20:
Remove extra line between code example and footer.
Line 21: Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075
--
To view, visit https://gerrit.ovirt.org/51407
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list