Change in vdsm[master]: virt: Don't create <bios> on non-x86 architectures

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 12 18:50:14 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: Don't create <bios> on non-x86 architectures
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Looks good, waiting for Francesco ack.

https://gerrit.ovirt.org/#/c/51648/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: We introduced ovirt-vmconsole access to BIOS some time ago.  But that
Line 10: unfortunately breaks on PowerPC as there is no <bios> domain XML element
Line 11: there.  So we need to check whether we are on a supported architecture
Line 12: before inserting <bios> element.
> don't you have a 3.6 bug for that?
This feature was never backported to 3.6, so there is no bug.
Line 13: 
Line 14: Change-Id: I5912d9842d46c3fcbefc7e668912706af25c45fb


-- 
To view, visit https://gerrit.ovirt.org/51648
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5912d9842d46c3fcbefc7e668912706af25c45fb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list