Change in vdsm[master]: lib: avoid circular references due to wrapping

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 12 18:11:22 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: lib: avoid circular references due to wrapping
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/51630/2/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:

Line 120
Line 121
Line 122
Line 123
Line 124
> One problem is that recoverable or unrecoverable may depend on the error *a
Currently anything called with this wrapper will kill vdsm before the code above it can do anything. If we let the error bubble up, the code change the behavior based on context.


-- 
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list