Change in vdsm[master]: virt: Don't create <bios> on non-x86 architectures
mpolednik at redhat.com
mpolednik at redhat.com
Tue Jan 12 08:37:36 UTC 2016
Martin Polednik has posted comments on this change.
Change subject: virt: Don't create <bios> on non-x86 architectures
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/51648/2/tests/vmTests.py
File tests/vmTests.py:
Line 303: element = tree.find(".//bios[@useserial='yes']")
Line 304: self.assertEqual(element is not None, use_serial)
Line 305:
Line 306: @permutations([[caps.Architecture.PPC64], [caps.Architecture.PPC64LE]])
Line 307: def testSerialBiosPpc(self, arch):
> This duplicates the previous test. Better have one test, and include the th
Something minor that makes this approach not-so-nice: when running tests, it overflow's the 80 characters line quite a lot (causing the OK text to be misaligned). I wouldn't -1 for it though.
Line 308: devices = {'device': 'console', 'type': 'console',
Line 309: 'specParams': {'consoleType': 'serial'}},
Line 310: with fake.VM(devices=devices, create_device_objects=True,
Line 311: arch=arch) as fakevm:
--
To view, visit https://gerrit.ovirt.org/51648
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5912d9842d46c3fcbefc7e668912706af25c45fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list