Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

nsoffer at redhat.com nsoffer at redhat.com
Mon Jan 11 18:12:51 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: Don't expose GuestAgent.guestInfo directly
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/51508/4/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 358:         if self.isResponsive():
Line 359:             # Returning deep copy would be safer but could have performance
Line 360:             # implications (e.g. on lists of thousands installed Windows
Line 361:             # packages).
Line 362:             return self.guestInfo.copy()
This include list shared with the real guest info (e.g, appsList). If we convert them to tuples this would be more safe.
Line 363:         else:
Line 364:             return {
Line 365:                 'username': 'Unknown',
Line 366:                 'session': 'Unknown',


-- 
To view, visit https://gerrit.ovirt.org/51508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list