Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

fromani at redhat.com fromani at redhat.com
Mon Jan 11 16:20:41 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Correct epoll unregistration usage in vmchannels
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

preliminary review: seems OK, hence preliminary ack. Deeper review later.

https://gerrit.ovirt.org/#/c/51521/6/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 232:             # NOTE: unregister_fd has to be called here, otherwise it'd be
Line 233:             # removed from epoll after the socket has been closed, which is
Line 234:             # incorrect
Line 235:             if (fileno not in self._add_channels and
Line 236:                     fileno not in self._unconnected):
thanks for the parens :)
Line 237:                 self._unregister_fd(fileno)


-- 
To view, visit https://gerrit.ovirt.org/51521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list